[Refactor] Reuse webview test query client helper - #1088
Merged
Conversation
Contributor
Author
edelauna
approved these changes
Aug 1, 2026
edelauna
marked this pull request as ready for review
August 1, 2026 12:56
edelauna
requested review from
JamesRobert20,
hannesrudolph,
navedmerchant and
taltas
as code owners
August 1, 2026 12:56
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
createTestQueryClient()towebview-ui/src/utils/test-utils.tsxand reused it inside the shared Testing Libraryrenderwrapper.QueryClientProvidersetup fromContextWindowProgress.spec.tsxandChatRow.subtask-links.spec.tsxso those specs rely on the shared render wrapper.Why this change was made
This continues the approved test-utils rollout with an independent webview slice while the first pilot PR stays mergeable. The goal is still narrow: remove mechanical provider duplication without hiding test intent.
Impact
No user-facing behavior change. Webview tests get a clearer shared provider pattern, and the touched specs passed along with webview lint, typecheck, and the full Zoo-Code test suite.
Related PRs